Skip to content

Belenos

Frank requested to merge (removed):belenos into belenos

Greetings, I took the feedback and I changed some things:

  1. I added some lines at the beginning to check if the computer handles 3D acceleration: I decided not doing anything at first because I knew that compton-launcher already checks for that but then I realize that If the user is not properly informed, she/he could think it is a bug so I decided to do something about that. Please, could you check the lines 13 and 14? even though I did some tests to make sure it works, I don't have much experience in shell programming to be 100% sure.

  2. I decided to take the other way around about treating the user's imput because I felt that it was more intuitive to treat first if compton was running or not and then evaluate the user's action. Don't worry if the user starts or stops compton by their own, the scripts checks if it is running by looking at the computer's processes and I've already took at into account while I was writing it (No complications added, just treat everything normally)

  3. I think I went a little bit too far with the comments... But I prefer you to to decide if that was too much.

Thank you for your patience and I hope this is good enough to be included.

Merge request reports